Skip to content

dcou test only code in streamer #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025

Conversation

alexpyattaev
Copy link

Problem

streamer/src/nonblocking/recvmmsg.rs is not used outside of unittests but is exposed as pub fn.

Summary of Changes

  • DCOU a module we do not use outside of tests.

@alexpyattaev alexpyattaev requested a review from vadorovsky July 11, 2025 14:29
@alexpyattaev alexpyattaev marked this pull request as ready for review July 11, 2025 14:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (8e575e2) to head (92e5cee).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6936     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         856      856             
  Lines      377966   377966             
=========================================
- Hits       314798   314779     -19     
- Misses      63168    63187     +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Feel free to merge, but... I'm even wondering if we should just 🪓 it. I suppose that this whole module is just a leftover of someone's attempt to make our recv_mssg work with tokio? But it doesn't seem to be used that way anywhere.

We could always restore this code if needed.

@alexpyattaev
Copy link
Author

Well we dcou it first, this gives us the freedom to figure out when and how we want to axe it for good. After all, it is still used in a bunch of tests, so those would need to be updated.

@alexpyattaev alexpyattaev merged commit 8d614dd into anza-xyz:master Jul 12, 2025
52 checks passed
@alexpyattaev alexpyattaev deleted the dcou_recv_mmsg branch July 12, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants