pre-commit: add oxipng a lossless PNG compression optimizer #11065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Lossless compression is a data compression technique where the original data can be perfectly reconstructed from the compressed data. In essence, no information is lost during compression and decompression, making it ideal for situations where data integrity is critical" https://en.wikipedia.org/wiki/Lossless_compression https://github.com/oxipng/oxipng https://github.com/oxipng/oxipng?tab=readme-ov-file#git-integration-via-pre-commit Ran pre-commit here locally and it compressed the images on first run. So we have less data for some images with the same quality. Less data means less to download etc and saves bandwidth.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11065 +/- ##
=========================================
Coverage 16.57% 16.57%
- Complexity 13967 13968 +1
=========================================
Files 5743 5743
Lines 510468 510468
Branches 62073 62073
=========================================
+ Hits 84616 84617 +1
+ Misses 416390 416389 -1
Partials 9462 9462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks good @jbampton , but how would enforcing this with github actions work? Will it refuse not optimised pictures or automatically compress them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Lossless compression is a data compression technique where the original data can be perfectly reconstructed from the compressed data. In essence, no information is lost during compression and decompression, making it ideal for situations where data integrity is critical"
https://en.wikipedia.org/wiki/Lossless_compression
https://github.com/oxipng/oxipng
https://github.com/oxipng/oxipng?tab=readme-ov-file#git-integration-via-pre-commit
Ran pre-commit here locally and it compressed the images on first run.
So we have less data for some images with the same quality.
Less data means less to download etc and saves bandwidth.
Description
This PR adds another check / hook / test to our pre-commit framework.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran locally
pre-commit run --all-filesHow did you try to break this feature and the system with this change?