-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix HTML license; standardize HTML code #11067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used. We use lowercase for HTML so made the doctype lowercase as well to be consistent. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13877 |
@blueorangutan LLtest keepEnv |
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11067 +/- ##
============================================
+ Coverage 16.57% 17.47% +0.89%
- Complexity 13967 13968 +1
============================================
Files 5743 5329 -414
Lines 510468 476724 -33744
Branches 62073 55999 -6074
============================================
- Hits 84616 83296 -1320
+ Misses 416390 384121 -32269
+ Partials 9462 9307 -155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used.
We use lowercase for HTML so made the doctype lowercase as well to be consistent.
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?