Skip to content

Fix HTML license; standardize HTML code #11067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbampton
Copy link
Member

Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used.

We use lowercase for HTML so made the doctype lowercase as well to be consistent.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Authors are encouraged to omit the type attribute.  And the language attribute was never standardized and should not be used.

We use lowercase for HTML so made the doctype lowercase as well to be consistent.

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13877

@DaanHoogland
Copy link
Contributor

@blueorangutan LLtest keepEnv

@blueorangutan
Copy link

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.47%. Comparing base (5b7c3b4) to head (d64428a).
Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11067      +/-   ##
============================================
+ Coverage     16.57%   17.47%   +0.89%     
- Complexity    13967    13968       +1     
============================================
  Files          5743     5329     -414     
  Lines        510468   476724   -33744     
  Branches      62073    55999    -6074     
============================================
- Hits          84616    83296    -1320     
+ Misses       416390   384121   -32269     
+ Partials       9462     9307     -155     
Flag Coverage Δ
uitests ?
unittests 17.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants