Skip to content

Refactoring smoke tests #11107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

slavkap
Copy link
Contributor

@slavkap slavkap commented Jun 30, 2025

Description

This PR refactors StorPool's smoke tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

How did you try to break this feature and the system with this change?

Executed all tests on the latest main branch

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.90%. Comparing base (16c60c7) to head (4e0565d).
Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (16c60c7) and HEAD (4e0565d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (16c60c7) HEAD (4e0565d)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #11107       +/-   ##
=============================================
- Coverage     16.57%    3.90%   -12.67%     
=============================================
  Files          5743      414     -5329     
  Lines        510494    33743   -476751     
  Branches      62075     6065    -56010     
=============================================
- Hits          84617     1319    -83298     
+ Misses       416415    32266   -384149     
+ Partials       9462      158     -9304     
Flag Coverage Δ
uitests 3.90% <ø> (+<0.01%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Contributor

@slavkap can you check the license / lint errors.

@@ -0,0 +1,137 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might make sense to add this to the rat exclusion list (or add a license)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants