-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix handler for deploy button menu #11116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix handler for deploy button menu #11116
Conversation
Fixes issue where launch and stay is not working Signed-off-by: Abhishek Kumar <[email protected]>
502b809
to
c0b12e1
Compare
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11116 +/- ##
=========================================
Coverage 16.15% 16.15%
- Complexity 13277 13278 +1
=========================================
Files 5657 5657
Lines 497939 497939
Branches 60386 60386
=========================================
+ Hits 80443 80455 +12
+ Misses 408532 408520 -12
Partials 8964 8964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm, tested but only with regular VMs (not VNFs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwstppr looking good. Only one minor comment: when hovering the Launch Instance & stay on this page
button, the background color is white:
Could we address that in this PR?
thanks @bernardodemarco , will check and update |
Signed-off-by: Abhishek Kumar <[email protected]>
@bernardodemarco should be fixed now |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes issue where launch and stay is not working
Regression from #10814
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?