Skip to content

ui: fix handler for deploy button menu #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jul 2, 2025

Description

Fixes issue where launch and stay is not working
Regression from #10814

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes issue where launch and stay is not working

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 2, 2025

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr closed this Jul 2, 2025
@shwstppr shwstppr reopened this Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (ba0204f) to head (8a2c6b0).
Report is 7 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #11116   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13277    13278    +1     
=========================================
  Files          5657     5657           
  Lines        497939   497939           
  Branches      60386    60386           
=========================================
+ Hits          80443    80455   +12     
+ Misses       408532   408520   -12     
  Partials       8964     8964           
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11116 (QA-JID-656)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested but only with regular VMs (not VNFs)

@rohityadavcloud rohityadavcloud added this to the 4.20.2 milestone Jul 2, 2025
Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr looking good. Only one minor comment: when hovering the Launch Instance & stay on this page button, the background color is white:

image

Could we address that in this PR?

@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 2, 2025

thanks @bernardodemarco , will check and update

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 3, 2025

@bernardodemarco should be fixed now

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11116 (QA-JID-659)

Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernardodemarco should be fixed now

@shwstppr thanks!

lgtm, verified in the QA env:

image

@DaanHoogland DaanHoogland merged commit ed7bd5e into apache:4.20 Jul 3, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the fix-deploybtn-menu-handler branch July 3, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants