Upgrade noVNC from 1.4.0 to 1.6.0

[vishesh92]

Description

This PR upgrades noVNC from 1.4.0 to 1.6.0. Followed the same steps as in #7281. This should fix issues like #9940

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (16c60c7) to head (95ceffe).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11119   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
- Complexity    13968    13969    +1     
=========================================
  Files          5743     5743           
  Lines        510494   510494           
  Branches      62075    62075           
=========================================
+ Hits          84617    84622    +5     
+ Misses       416415   416410    -5     
  Partials       9462     9462           

Flag	Coverage Δ
uitests	3.90% <ø> (ø)
unittests	17.47% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13981

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11119 (QA-JID-657)

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13664)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56520 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11119-t13664-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_isolate_network_FW_PF_default_routes_egress_true	Failure	114.80	test_routers_network_ops.py
test_01_vpc_site2site_vpn_multiple_options	Failure	407.88	test_vpc_vpn.py

[Copilot]

Pull Request Overview

Upgrades noVNC from version 1.4.0 to 1.6.0, replacing low-level send/receive calls with buffered queue methods and adding modern codec support, along with UI embedding improvements and dependency bumps.

• Bumped noVNC version to 1.6.0 and added empty defaults.json/mandatory.json stubs
• Replaced direct .send/.sendString calls with sQpush* and .flush() in Websock and RFB
• Introduced Zlib and H264 decoding support, refactored UI initialization in vnc.html

Reviewed Changes

Copilot reviewed 73 out of 73 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
systemvm/agent/noVNC/package.json	Bump version to 1.6.0, update devDependencies
systemvm/agent/noVNC/defaults.json	Add empty defaults placeholder
systemvm/agent/noVNC/mandatory.json	Add empty mandatory placeholder
systemvm/agent/noVNC/vnc_lite.html	Minor text casing/style tweaks
systemvm/agent/noVNC/vnc.html	Refactor UI startup to dynamic imports and fetch settings
systemvm/agent/noVNC/utils/convert.js	Use destructured program import from commander
systemvm/agent/noVNC/core/websock.js	Migrate to sQpush*/flush API for send queue buffering
systemvm/agent/noVNC/core/rfb.js	Enhanced resize logic, new Zlib/H264 encodings, pointer events
systemvm/agent/noVNC/core/decoders/*.js	Add ZlibDecoder and H264Decoder, update existing decoders
systemvm/agent/noVNC/core/util/*.js	Standardize copyright casing, correct utility methods
systemvm/agent/noVNC/docs/novnc_proxy.1	Update --listen synopsis to support [HOST:]PORT syntax

Comments suppressed due to low confidence (2)

systemvm/agent/noVNC/core/decoders/h264.js:1

• [nitpick] The new H264 decoder logic is substantial but lacks dedicated unit tests; consider adding tests to validate parsing, key-frame handling, and decoder configuration.

/*

systemvm/agent/noVNC/core/rfb.js:2560

• [nitpick] replaceAll is not supported in some older browsers; consider using textData = textData.replace(/\r\n/g, "\n"); for wider compatibility.

                    textData = textData.replaceAll("\r\n", "\n");