systemvm: build 4.20.2 template with 'depmod -a' #11128

weizhouapache · 2025-07-03T06:56:16Z

Description

This PR may fix the issue with Vmware 8.0.3 with ACS 4.20.1.0

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-07-03T06:56:29Z

@blueorangutan package

blueorangutan · 2025-07-03T06:58:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-07-03T07:03:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (544028c) to head (36e0cf5).
Report is 7 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11128   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13277    13278    +1     
=========================================
  Files          5657     5657           
  Lines        497939   497939           
  Branches      60386    60386           
=========================================
+ Hits          80450    80454    +4     
+ Misses       408525   408520    -5     
- Partials       8964     8965    +1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.00% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti

changes lgtm

Copilot

Pull Request Overview

This PR updates the system VM template build to version 4.20.2.0 and injects a depmod -a step into the finalize script to address module dependency issues on VMware.

Added depmod -a in finalize.sh to regenerate kernel module dependencies
Bumped project.systemvm.template.version in pom.xml from 4.20.1.0 to 4.20.2.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tools/appliance/systemvmtemplate/scripts/finalize.sh	Inserted `depmod -a` at the start of `finalize()`
pom.xml	Updated `<project.systemvm.template.version>` to `4.20.2.0`

Comments suppressed due to low confidence (3)

tools/appliance/systemvmtemplate/scripts/finalize.sh:71

[nitpick] Add a brief comment above this line to explain why depmod -a is needed (e.g., "# rebuild module dependency map after installing modules"), improving maintainability.

  depmod -a

pom.xml:53

[nitpick] After bumping the template version here, update any relevant release notes or user-facing documentation to reference the new 4.20.2.0 template.

        <project.systemvm.template.version>4.20.2.0</project.systemvm.template.version>

tools/appliance/systemvmtemplate/scripts/finalize.sh:71

Using depmod without an absolute path may fail if /sbin isn't in PATH during build. Consider calling /sbin/depmod -a or validating the PATH.

  depmod -a

blueorangutan · 2025-07-03T08:42:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14000

DaanHoogland

clgtm, so we are not releasing a new svm template for 4.20.1?

weizhouapache · 2025-07-03T13:52:05Z

clgtm, so we are not releasing a new svm template for 4.20.1?

ACS 4.20.1.0 has been released

I think the next systemvm template would be 4.20.2
users can use ACS 4.20.1.0 and systemvm template 4.20.2, it should work

blueorangutan · 2025-07-04T06:41:04Z

[SF] Trillian test result (tid-13667)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73744 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11128-t13667-vmware-80u3.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	184.60	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	50.27	test_affinity_groups.py
test_deploy_more_vms_than_limit_allows	`Error`	214.41	test_deploy_vms_in_parallel.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	56.92	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.10	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	208.67	test_kubernetes_clusters.py
test_01_deployVMInSharedNetwork	`Error`	411.67	test_network.py
test_01_non_strict_host_anti_affinity	`Failure`	265.13	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	101.13	test_nonstrict_affinity_group.py
test_02_restore_vm_with_disk_offering	`Error`	57.12	test_restore_vm.py
ContextSuite context=TestMigrateVMStrictTags>:setup	`Error`	0.00	test_vm_strict_host_tags.py

weizhouapache · 2025-07-04T07:11:54Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-07-04T07:14:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

blueorangutan · 2025-07-05T05:01:48Z

[SF] Trillian test result (tid-13671)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 76067 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11128-t13671-vmware-80u3.zip
Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	`Error`	462.14	test_network.py
test_01_add_primary_storage_disabled_host	`Error`	0.24	test_primary_storage.py
test_03_migration_options_storage_tags	`Error`	0.02	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	13.70	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	13.70	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	171.17	test_snapshots.py
test_01_deploy_vm_on_specific_host	`Error`	0.09	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.12	test_vm_deployment_planner.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	73.55	test_vm_life_cycle.py
test_01_vapps_vm_cycle	`Error`	21.54	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	0.07	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	0.27	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.26	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	0.24	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.26	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	0.26	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	0.30	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	0.31	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	5.82	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.25	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	5.89	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.25	test_vm_strict_host_tags.py

weizhouapache · 2025-07-05T06:46:40Z

@blueorangutan test ol8 vmware-80u3

blueorangutan · 2025-07-05T06:48:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

blueorangutan · 2025-07-06T05:47:17Z

[SF] Trillian test result (tid-13689)
Environment: vmware-80u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 80296 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11128-t13689-vmware-80u3.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3695.02	test_kubernetes_clusters.py
test_01_deployVMInSharedNetwork	`Error`	431.84	test_network.py
test_01_scale_vm	`Error`	1.49	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	1.35	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	1.33	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	10.56	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	1.38	test_scale_vm.py

systemvm: build 4.20.2 template with 'depmod -a'

36e0cf5

boring-cyborg bot added component:build component:templates systemvm-template-change labels Jul 3, 2025

sureshanaparti requested a review from Copilot July 3, 2025 07:56

sureshanaparti approved these changes Jul 3, 2025

View reviewed changes

Copilot AI reviewed Jul 3, 2025

View reviewed changes

sureshanaparti requested a review from DaanHoogland July 3, 2025 10:03

sureshanaparti added this to the 4.20.2 milestone Jul 3, 2025

DaanHoogland approved these changes Jul 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

systemvm: build 4.20.2 template with 'depmod -a' #11128

systemvm: build 4.20.2 template with 'depmod -a' #11128

weizhouapache commented Jul 3, 2025

Uh oh!

weizhouapache commented Jul 3, 2025

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

codecov bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

sureshanaparti left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

DaanHoogland left a comment

Uh oh!

weizhouapache commented Jul 3, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

weizhouapache commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

weizhouapache commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 6, 2025

Uh oh!

Uh oh!

systemvm: build 4.20.2 template with 'depmod -a' #11128

Are you sure you want to change the base?

systemvm: build 4.20.2 template with 'depmod -a' #11128

Conversation

weizhouapache commented Jul 3, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Jul 3, 2025

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 3, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

weizhouapache commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

weizhouapache commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 6, 2025

Uh oh!

Uh oh!

codecov bot commented Jul 3, 2025 •

edited

Loading