-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor SortMergeJoinMetrics to reuse BaselineMetrics #16675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alan Tang <[email protected]>
lgtm |
Signed-off-by: Alan Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Standing-Man I would suggest to capture only num rows instead of entire batch, similar to
metrics.record_output(sorted.num_rows()); |
Signed-off-by: Alan Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @Standing-Man
Which issue does this PR close?
SortMergeJoinMetrics
to reuseBaselineMetrics
#16493.Rationale for this change
Refactor SortMergeJoinMetrics to reuse BaselineMetrics
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?