Skip to content

Refactor SortMergeJoinMetrics to reuse BaselineMetrics #16675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

Standing-Man
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Refactor SortMergeJoinMetrics to reuse BaselineMetrics

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-plan Changes to the physical-plan crate label Jul 4, 2025
@jatin510
Copy link
Contributor

jatin510 commented Jul 4, 2025

lgtm

Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Standing-Man I would suggest to capture only num rows instead of entire batch, similar to

metrics.record_output(sorted.num_rows());

@Standing-Man Standing-Man requested a review from comphead July 5, 2025 00:29
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @Standing-Man

@alamb alamb merged commit 698155a into apache:main Jul 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-plan Changes to the physical-plan crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor SortMergeJoinMetrics to reuse BaselineMetrics
5 participants