Skip to content

JAMES-4133 Add support for unicode adddresses as defined in RFC6532. #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arnt
Copy link

@arnt arnt commented May 22, 2025

This adds Domain tests and does enough to parse unicode email addresses.

However, I'm not quite happy. This needs documentation changes, I wouldn't mind another few Domain tests, and I do want to investigate what's up with Jakarta and संपर्क@डाटामेल.भारत but haven't time to do that this week.

Consider it a WIP.

@chibenwa chibenwa changed the title WIP: Add support for unicode adddresses as defined in RFC6532. JAMES-4133 Add support for unicode adddresses as defined in RFC6532. May 23, 2025
@chibenwa chibenwa marked this pull request as draft May 23, 2025 07:15
@chibenwa
Copy link
Contributor

chibenwa commented May 23, 2025

Hello @arnt

Thanks for this major contribution.

I did update #2724 with your changes and can happily say the SMTP-IN stack in James is RFC-6532 compliant :-)

However, I did face major issues as any modification (header for instance, but also the defensive copy done in the memory mail queue) causes the loss of the UTF-8 characters. This clearly see like a lack of support for RFC-6532 from jakarta.mail.internet.MimeMessage which James (sadly...) still heavily relies on. (quick checks tends to confirm this dependency do not support RFC-6532).

BTW I did turn the PR into a draft and add the ticket number into the title in order to make this clear.

Best regards,

Benoit TELLIER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants