Skip to content

Fix - markersDirectory is not working when unpack goal is executed from command line #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vaibhavbatra15
Copy link
Contributor

@vaibhavbatra15 vaibhavbatra15 commented Jun 14, 2025

fixes #536

Property attribute is missing in @parameter annotation from markersDirectory attribute in UnpackMojo due to which its not working from command line.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test, probably an integration test

@vaibhavbatra15
Copy link
Contributor Author

@elharo Can you point me to any existing integration test written in this project?
I can refer that and write test on similar lines.

@elharo
Copy link
Contributor

elharo commented Jun 21, 2025

@slawekjaranowski slawekjaranowski changed the title Fix - markersDirectory is not working when unpack goal is executed fr… Fix - markersDirectory is not working when unpack goal is executed from command line Jun 24, 2025
@slawekjaranowski slawekjaranowski added the bug Something isn't working label Jul 6, 2025
@slawekjaranowski slawekjaranowski added this to the next-release milestone Jul 6, 2025
@slawekjaranowski slawekjaranowski merged commit 4a86976 into apache:master Jul 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markersDirectory is not working when unpack goal is executed from command line
3 participants