-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[fix][test][branch-3.0] Correct topic policy loading logic and improve related tests #24451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-3.0
Are you sure you want to change the base?
Conversation
I'm sorry I missed this. Thanks for fixing. I pushed this commit directly to branch-3.0 so that it doesn't mix the review. 2061f681 |
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
38054c5
to
db15cc6
Compare
@lhotari You can directly push this pr to the branch-3.0, or use merge button. |
@nodece Do these tests ever pass or are they completely broken? |
Some tests have failed:
I don't have time to handle the |
Signed-off-by: Zixuan Liu <[email protected]>
db15cc6
to
9f734fd
Compare
Now, |
Signed-off-by: Zixuan Liu <[email protected]>
Motivation
#24279 breaks the branch-3.0 CI.
Modifications
testCheckPersistencePolicies
to align with updated topic policy loading behavior.ExtensibleLoadManagerCloseTest
test groups toflaky
, which always fail.Documentation
doc
doc-required
doc-not-needed
doc-complete