Skip to content

[SPARK-51035][BUILD] Upgrade Janino to 3.1.12 #51239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YanivKunda
Copy link

What changes were proposed in this pull request?

Upgrade of Janino to 3.1.12

Why are the changes needed?

Security vulnerability CVE-2023-33546.
While not probably that standard user input could exploit this vulnerability,
upgrading will:

  1. Future-proof against changes that might introduce user input
  2. Reduce flagging by scanners

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests ran

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Jun 21, 2025
@HyukjinKwon HyukjinKwon changed the title SPARK-51035 - upgraded Janino to 3.1.12 [SPARK-51035][BUILD] Upgrade Janino to 3.1.12 Jun 23, 2025
@HyukjinKwon
Copy link
Member

Let's rerun the tests to make sure all tests pass

@YanivKunda
Copy link
Author

Let's rerun the tests to make sure all tests pass

It seems to have failed on OOM while compiling with sbt:
https://github.com/YanivKunda/spark/actions/runs/15823583629/job/44604304923

I've pushed a 50% increase in sbt default mem to test if that helps.

@YanivKunda YanivKunda force-pushed the SPARK-51035_upgrade_janino_to_3.1.12 branch from 451daf4 to 5edc7a0 Compare June 24, 2025 08:57
@YanivKunda YanivKunda force-pushed the SPARK-51035_upgrade_janino_to_3.1.12 branch from 5edc7a0 to a7e3612 Compare June 24, 2025 08:59
@github-actions github-actions bot added the SQL label Jun 24, 2025
@YanivKunda
Copy link
Author

@HyukjinKwon can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants