-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-52563][PS] Fix var naming bug in _assert_pandas_almost_equal #51253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
First PR to spark. I would appreciate some help with creating the Jira issue. It didn't seem like I can create one myself or create a Jira account for Apache |
Thanks for contribution! |
Yep, just did. I only recently realized I could request an account so I can create tickets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Would be great to add a test case for it.
@allisonwang-db I actually don't really see a good test we could write here? Do you? This function is actually a nested function (so more like a lambda) that is inside of a private function ( Interestingly, this PR shouldn't change the behavior of the code at all since the variables |
Looks like the inner function is used in this case:
|
Yes, it certainly is used, but my point was that it's still nested inside the @allisonwang-db What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petern48 Thanks for fixing the bug and adding the test cases!
Merged to master. |
What changes were proposed in this pull request?
Small bug fix where the wrong variable names were used
Why are the changes needed?
The function uses lval and rval instead of the parameters val1 and val2
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No