[SPARK-51885][SQL] Change AnalysisContext.outerPlan from Option[LogicalPlan] to Seq[LogicalPlan] #51274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
request @vladimirg-db for review, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr only contains non-functional change.
AnalysisContext.outerPlandefinition fromOption[LogicalPlan]toSeq[LogicalPlan]AnalysisContext.outerPlaninResolveSubqueryandresolveOuterRefto get theheadOptionof the Sequence.Why are the changes needed?
This is the necessary definition change for supporting resolving nested correlated subqueries.
The outerPlan currently stores the direct outer plan only so it can be defined as Option[LogicalPlan].
For supporting resolving nested correlated subqueries, it should store all the outer plans as a sequence of outerPlans, and the resolver/ColumnResolutionHelper should search the attribute from the inner most scope to the outer most scope.
Does this PR introduce any user-facing change?
No, this pr only contains non-functional change.
How was this patch tested?
No additional tests needed as this pr only contains non-functional change.
Was this patch authored or co-authored using generative AI tooling?
No