[FFI] Enhance FFI Object exception safety during init #18050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enhances the exception safety of FFI Object during init. Specifically, when an error is thrown during init before __init_by_constructor chandle can be in a undefined state. Additionally, tools like pytest may try to call repr to get a string repr the object, causing segfault. This PR fixes the issue by always first initialize chandle to NULL and provide chandle=None special handling so pytest can be happy in such cases.
spectrometerHBH
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the exception safety of FFI Object during init. Specifically, when an error is thrown during init before __init_by_constructor chandle can be in a undefined state. Additionally, tools like pytest may try to call repr to get a string repr the object, causing segfault.
This PR fixes the issue by always first initialize chandle to NULL and provide chandle=None special handling so pytest can be happy in such cases.