-
Notifications
You must be signed in to change notification settings - Fork 158
feat: add merge queue support to GitHub Actions workflow #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@DmitriyLewen The documentation about bypassing the merge queue has been removed from GitHub. It might be working now even without adding a bypass. Could you approve this PR? |
Looks like it works 👍 |
Hmm. The merge queue removed this PR. I'll add a bypass workflow. |
name: license/cla | ||
runs-on: ubuntu-latest | ||
steps: | ||
- run: 'echo "No test required"' |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 9 days ago
To fix the issue, we need to add a permissions
block to the workflow. Since the workflow does not require write access or any special permissions, we will set the permissions to contents: read
. This ensures the workflow adheres to the principle of least privilege and avoids inheriting potentially excessive permissions from the repository.
The permissions
block should be added at the root level of the workflow, as it applies to all jobs unless overridden by job-specific permissions.
-
Copy modified lines R3-R4
@@ -2,2 +2,4 @@ | ||
name: CLA | ||
permissions: | ||
contents: read | ||
on: |
Summary
merge_group
trigger to GitHub Actions workflow to support GitHub merge queue functionalityChanges
.github/workflows/go.yml
to includemerge_group
event trigger alongside existingpush
andpull_request
triggersTest plan
Background
This change is required for GitHub merge queue to function properly. Without the
merge_group
trigger, status checks will not be triggered when PRs are added to a merge queue, causing merges to fail due to missing required status checks.References: