Skip to content

feat(echo): Add Echo Support #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2025
Merged

Conversation

orizerah
Copy link
Contributor

@orizerah orizerah commented May 6, 2025

Adding support for Echo Images to Trivy
The advisory json file is pulled from https://advisory.echohq.com/data.json

Relevant Discussion: aquasecurity/trivy#8834

@DmitriyLewen
Copy link
Contributor

DmitriyLewen commented May 20, 2025

Can you also add Echo in README.md, please.

And will be great to see that it works in GitHub CI/CD (you can create fork of vuln-list and run action for this PR).

@orizerah
Copy link
Contributor Author

@DmitriyLewen I went over the comments and addressed them all.

Here's a working GitHub action
https://github.com/orizerah/vuln-list-update/actions/runs/15144338839/job/42576210143

Here's the fork with the new echo dir
https://github.com/orizerah/vuln-list/tree/main/echo

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left small refactor/test comments

@orizerah
Copy link
Contributor Author

@DmitriyLewen, I went through all of the comments :)

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizerah Thanks for your contribution and patience :)
LGTM

Can you run the update action again just in case?

cc. @knqyf263

@orizerah
Copy link
Contributor Author

orizerah commented May 21, 2025

@DmitriyLewen I ran it again
https://github.com/orizerah/vuln-list-update/actions/runs/15155862378/job/42610547961

Thank you for your time :)

@knqyf263 knqyf263 merged commit eb71601 into aquasecurity:main May 21, 2025
2 checks passed
knqyf263 added a commit that referenced this pull request May 21, 2025
DmitriyLewen pushed a commit that referenced this pull request May 21, 2025
package echo

type Advisory map[string]map[string]struct {
Severity string `json:"severity,omitempty"`
Copy link
Contributor

@DmitriyLewen DmitriyLewen May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @orizerah
I'm checking the thivy-db from aquasecurity/trivy-db#528 (comment)

I found that https://advisory.echohq.com/data.json doesn't have severity fields.
Why did you add this field?
Does echo plan to add severity levels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wanted to have that option

DmitriyLewen added a commit to DmitriyLewen/vuln-list-update that referenced this pull request May 29, 2025
@DmitriyLewen DmitriyLewen mentioned this pull request May 29, 2025
2 tasks
DmitriyLewen added a commit that referenced this pull request May 29, 2025
Revert "Revert "feat(echo): Add Echo Support (#350)" (#352)" (#353)
This reverts commit 9a2a743.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants