-
Notifications
You must be signed in to change notification settings - Fork 107
feat(echo): Add Echo Support #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you also add And will be great to see that it works in GitHub CI/CD (you can create fork of |
@DmitriyLewen I went over the comments and addressed them all. Here's a working GitHub action Here's the fork with the new echo dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left small refactor/test comments
@DmitriyLewen, I went through all of the comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitriyLewen I ran it again Thank you for your time :) |
package echo | ||
|
||
type Advisory map[string]map[string]struct { | ||
Severity string `json:"severity,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @orizerah
I'm checking the thivy-db from aquasecurity/trivy-db#528 (comment)
I found that https://advisory.echohq.com/data.json doesn't have severity fields.
Why did you add this field?
Does echo
plan to add severity levels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to have that option
…asecurity#352)" This reverts commit 9a2a743.
Adding support for Echo Images to Trivy
The advisory json file is pulled from https://advisory.echohq.com/data.json
Relevant Discussion: aquasecurity/trivy#8834