Partials v2 #12
Draft
Partials v2 #12
+6,400
−618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like __call trampolines, we can use an opcode-based trampoline to reduce recursion/reentering, and reuse the call frame of the trampoline. Also: Rebase fixes, update tests, add tests.
Girgias
reviewed
Jun 29, 2025
Comment on lines
+208
to
+209
| /* Internal functions use an incompatible arg_info struct | ||
| * TODO: unify zend_arg_info / zend_internal_arg_info? */ |
There was a problem hiding this comment.
This would be nice to do, but that would require allocating zend_strings rather than using C strings which are inside the binary. Would make a lot of other stuff simpler tho.
Girgias
reviewed
Jun 29, 2025
Zend/zend_types.h
Outdated
Comment on lines
669
to
671
| /* used for place holders */ | ||
| #define _IS_PLACEHOLDER_ARG 20 | ||
| #define _IS_PLACEHOLDER_VARIADIC 21 |
|
It looks like we still need a test for partially applying an invokable object that isn't a Closure. |
TimWolla
reviewed
Jul 2, 2025
| $f = f(?, ?); | ||
|
|
||
| $f(1, 2); | ||
|
|
There was a problem hiding this comment.
Please add a closing PHP tag in every test.
There was a problem hiding this comment.
We should have a linter for this kind of things :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on php#6898.
With the following changes:
trampolineis now a user function. This avoids re-entering the VM, and allows to re-use the trampoline stack frame when calling the real function. This is similar to__calltrampolines.trampolineandprototypeare merged into a singlezend_function. This simplifies a few things and speeds up PFA creation a bit.ZEND_ACC_andZEND_CALL_flags since there are no free slots anymorenewis not allowedStill a WIP. There are a few things to check and cleanup.
TODO: