Skip to content

Use native WebKit on macOS #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Use native WebKit on macOS #713

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2daa6fa
Remove WebKit From ThreadView Header
c-alpha Aug 9, 2021
f547c6f
[ThreadView] Use Private Struct Everywhere
c-alpha Aug 10, 2021
dc427f4
[ThreadView] Use Class Instead of Struct
c-alpha Aug 10, 2021
354c743
[ThreadView] Impl Class Stuff Must Be Public
c-alpha Aug 10, 2021
53dc3c2
[ThreadView] Missing Typecast in GObject Signal Callbacks
c-alpha Aug 10, 2021
ac4ab46
[ThreadView] Fix Typecasts
c-alpha Aug 10, 2021
9a8f781
[ThreadView] Ctor/Dtor Adjustments for PIMPL Pattern
c-alpha Aug 10, 2021
b872617
[ThreadView] Private Implementation Pointer Bot Easy to Spot
c-alpha Aug 10, 2021
f8b3f8f
[ThreadView] Refactoring Fixup
c-alpha Aug 10, 2021
792b313
[PageClient] Start Refactoring PageClient
c-alpha Aug 23, 2021
4ed239c
[PageClient] clean up internal pImpl references (fingers crossed)
c-alpha Aug 23, 2021
93e458e
[PageClient] move g_signal_(dis)connect to ThreadView
c-alpha Aug 23, 2021
305263d
[PageClient] broken self references
c-alpha Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[PageClient] broken self references
  • Loading branch information
@c-alpha
c-alpha committed Aug 23, 2021
commit 305263d07d06181c90031b737dd603c1a3a3c19f
4 changes: 2 additions & 2 deletions src/modes/thread_view/page_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ namespace Astroid {
eaddr);

/* listen */
self.srv->accept_async (sigc::mem_fun (this, &PageClient::extension_connect));
self.srv->accept_async (sigc::mem_fun (self, &PageClient::extension_connect));
umask (p);

/* send socket address (TODO: include key) */
Expand Down Expand Up @@ -142,7 +142,7 @@ namespace Astroid {
WebKitWebContext * context,
gpointer user_data) {

((PageClient *) user_data)->pImpl->init_web_extensions (((PageClient *) user_data), context);
((PageClient *) user_data)->pImpl->init_web_extensions ( * ((PageClient *) user_data), context);
}

PageClient::~PageClient () {
Expand Down