Deprecating --hard option in network clean command #2849
Conversation
Tonix517
force-pushed
the
tonyz/deprecate_clean_hard
branch
from
5792f94 to
b87d6fb
Compare
Tonix517
requested review from
learyce,
jasonatran,
sukantoraymond,
artemanosov,
meaghanfitzgerald and
cwend-ava
Tonix517
changed the title
|
|
cmd/networkcmd/clean.go
Outdated
| } | ||
| ux.Logger.PrintToUser("removing all downloaded avalanchego and plugin binaries") | ||
| binDir := filepath.Join(app.GetBaseDir(), constants.AvalancheCliBinDir) | ||
| cleanBins(binDir) |
There was a problem hiding this comment.
I mean, we don't even need this functionality just don;t do it. Lets keep the downloaded binaries after a clean.
There was a problem hiding this comment.
removed this block
tests/e2e/testcases/network/suite.go
Outdated
| @@ -117,7 +117,7 @@ var _ = ginkgo.Describe("[Network]", ginkgo.Ordered, func() { | |||
| commands.DeleteSubnetConfig(subnetName) | |||
| }) | |||
|
|
|||
| ginkgo.It("clean hard deletes plugin binaries non SOV", func() { | |||
| ginkgo.It("clean deletes plugin binaries non SOV", func() { | |||
There was a problem hiding this comment.
we don't need this one, if we are not removing binaries anymore
There was a problem hiding this comment.
to confirm: do we want to do ResetPluginsDir anyway at clean?
we don't want to continue deleted this, I also made the same comment in parallel |
Tonix517
force-pushed
the
tonyz/deprecate_clean_hard
branch
from
b87d6fb to
7f788b8
Compare
Tonix517
force-pushed
the
tonyz/deprecate_clean_hard
branch
2 times, most recently
from
8523b89 to
298ff2e
Compare
Tonix517
force-pushed
the
tonyz/deprecate_clean_hard
branch
from
298ff2e to
d3e9210
Compare
Why this should be merged
to address #2784 (comment)
How this works
How this was tested
How is this documented