Skip to content

build(deps): update bincode requirement from 1.3.3 to 2.0.1 #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 11, 2025

Updates the requirements on bincode to permit the latest version.

Release notes

Sourced from bincode's releases.

v2.0.1

What's Changed

New Contributors

Full Changelog: bincode-org/bincode@v2.0.0...v2.0.1

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Mar 11, 2025
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0.1 branch 3 times, most recently from 6399d27 to 0d44d3d Compare March 24, 2025 18:05
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0.1 branch 2 times, most recently from d6e26fc to 7b2a214 Compare March 26, 2025 16:01
Updates the requirements on [bincode](https://github.com/bincode-org/bincode) to permit the latest version.
- [Release notes](https://github.com/bincode-org/bincode/releases)
- [Commits](bincode-org/bincode@v1.3.3...v2.0.1)

---
updated-dependencies:
- dependency-name: bincode
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0.1 branch 2 times, most recently from eed886b to 1baf517 Compare March 26, 2025 22:46
Updates the requirements on [bincode](https://github.com/bincode-org/bincode) to permit the latest version.
- [Release notes](https://github.com/bincode-org/bincode/releases)
- [Commits](bincode-org/bincode@v1.3.3...v2.0.1)

---
updated-dependencies:
- dependency-name: bincode
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/bincode-2.0.1 branch from 1baf517 to ba43bec Compare March 26, 2025 23:08
rkuris added 3 commits March 26, 2025 20:24
…firewood into dependabot/cargo/bincode-2.0.1
Too bad the compiler is a little confused here. When debug!() does
nothing, the compiler thinks it should just return the original value
rather than assigning it. But we might want the original value in the
debug!(), so we'll just suppress this warning.
@rkuris
Copy link
Collaborator

rkuris commented Mar 27, 2025

This fix results in a significant performance drop. However, we aren't really using these serde serialization routines (see #831 for details), so it's probably okay to accept this upgrade, but let's remove the remaining few references to bincode in storage (there are only 2) instead and eliminate serde completely.

     Running benches/serializer.rs (/Users/rkuris/open-source/firewood/target/release/deps/serializer-6c232d65bd4e75a9)
leaf/serde              time:   [68.241 ns 68.289 ns 68.344 ns]
                        change: [+55.131% +55.558% +56.038%] (p = 0.00 < 0.05)
                        Performance has regressed.
has_value/serde         time:   [227.29 ns 232.01 ns 236.74 ns]
                        change: [+174.86% +179.75% +185.71%] (p = 0.00 < 0.05)
                        Performance has regressed.
1_child/serde           time:   [159.84 ns 160.33 ns 160.92 ns]
                        change: [+125.21% +126.52% +127.74%] (p = 0.00 < 0.05)
                        Performance has regressed.
2_child/serde           time:   [224.46 ns 228.42 ns 232.66 ns]
                        change: [+201.43% +206.56% +212.13%] (p = 0.00 < 0.05)
                        Performance has regressed.
16_child/serde          time:   [454.87 ns 460.94 ns 467.77 ns]
                        change: [+90.554% +92.788% +95.156%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rkuris rkuris marked this pull request as draft April 16, 2025 20:20
@rkuris rkuris removed the request for review from richardpringle April 16, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant