Skip to content

Merge upstream master to fork master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 1, 2018
Merged

Merge upstream master to fork master #1

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d154182
Added support for indexers instead of properties for the DataType.
dr-BEat Aug 22, 2018
a1f5b73
Avoid assumptions on parameters
dr-BEat Aug 23, 2018
ab2fb08
Passed right parameters to setter.
dr-BEat Aug 23, 2018
6d849ab
Added Tests for persistence with dynamic data
dr-BEat Aug 23, 2018
3e0899b
Fixed naming and visibility of storage dictionary in dynamic data tests
dr-BEat Aug 23, 2018
d9f0237
Properties instead of public field
dr-BEat Aug 24, 2018
b33b86c
Fixed indentation to match previous code
dr-BEat Sep 10, 2018
976a8ab
Added dynamic data test to WorkflowExecutorFixture
dr-BEat Sep 10, 2018
ee4272f
Fixed spelling mistakes in DefinitionLoaderTests
dr-BEat Sep 10, 2018
de172a0
Added DefinitionLoader unittests for dynamic stored workflow definitions
dr-BEat Sep 17, 2018
5409367
bump versions
danielgerlag Sep 24, 2018
29600de
Merge pull request #173 from dr-BEat/feat/DictionaryDataSupport
danielgerlag Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid assumptions on parameters
  • Loading branch information
@dr-BEat
dr-BEat committed Aug 23, 2018
commit a1f5b732fd084fdc7ac0f0b13fecdbae6ae8735c
5 changes: 3 additions & 2 deletions src/WorkflowCore/Services/FluentBuilders/ExpressionHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public static Expression<Action<TObject, TParam>> CreateSetter<TObject, TParam>(

public static LambdaExpression CreateSetter(LambdaExpression getterExpression)
{
var thisParameter = getterExpression.Parameters.Single();
var valueParameter = Expression.Parameter(getterExpression.ReturnType, "value");
Expression assignment;
if (getterExpression.Body is MethodCallExpression callExpression && callExpression.Method.Name == "get_Item")
Expand All @@ -48,7 +47,9 @@ public static LambdaExpression CreateSetter(LambdaExpression getterExpression)
{
assignment = Expression.Assign(getterExpression.Body, valueParameter);
}
return Expression.Lambda(assignment, thisParameter, valueParameter);

var parameters = getterExpression.Parameters.Concat(new[] {valueParameter}).ToArray();
return Expression.Lambda(assignment, parameters);
}
}
}