Skip to content

fix: endpoint name issues for dkr.api and others #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: endpoint name issues for dkr.api and others #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aec1bc
fix: endpoint name issues for dkr.api and others
DannyBlazejczak May 13, 2024
d3a0ea2
fix optional parameter
DannyBlazejczak May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/vpc-interface-endpoints-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ export class VpcInterfaceEndpointsStack extends BuilderVpc {
props.interfaceList.forEach((endpointName, index) => {
// Our first three positions are com.amazonaws.{region}. We'll retain after that and sub our . for a -
let endpointNameTemp = endpointName.split(".");
endpointNameTemp.splice(0, 3);
const endpointNameShort = endpointNameTemp.join("-");
// endpoint for ecr.dkr was incorrectly named ecr-dkr
// "The Vpc Endpoint Service 'com.amazonaws.ap-southeast-2.ecr-dkr' does not exist (Service: Ec2, Status Code: 400"
// It is incorrect to assume that all endpoint service names use a dash, e.g. ecr.drk, ecr.api, airflow.api, airflow.env, airflow.ops, sagemaker.api, sagemaker.runtime-fips
// There are no fast rules here, take the input from the configuration instead.
const removed = endpointNameTemp.splice(0, 3);
const endpointNameShort = endpointName.replace(removed.join('.') + '.', '');

const endpoint = new ec2.InterfaceVpcEndpoint(
this,
Expand All @@ -102,7 +106,12 @@ export class VpcInterfaceEndpointsStack extends BuilderVpc {
}

// Create our private hosted zone where we have a private DNS name is available from our service
const endpointPrivateDnsName = this.lookupPrivateDnsName(endpointName);
// "Invalid request provided: Creation of hosted zone with a wildcard domain name is not supported. (Service: Route53, Status Code: 400"
// For the privateDnsName using 'ecr.dkr' resolved wrongly to '*.dkr.ecr.ap-southeast-2.amazonaws.com.'
// The tool discoverEndpoints was ran and did not update the privateDnsName for the endpoint, to remove the *. prefix
// which is invalid for DNS names. There are many endpoints with this issue.
// Hence removing the *. in front of the dns name here.
const endpointPrivateDnsName = this.lookupPrivateDnsName(endpointName)?.replace('*.', '');
// Confirm this endpoint is available in all the AZs our stack will be deployed to
if(!this.serviceAvailableInAllAzs(endpointName)) {
throw new Error(`Endpoint ${endpointName} is not available in all Availability Zones: ${this.availabilityZones.join(',')}`)
Expand Down