Skip to content

Mark temporarily failing test as xfail #9563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025

Conversation

AndrewAsseily
Copy link
Contributor

@AndrewAsseily AndrewAsseily commented Jun 19, 2025

Description of changes: Temporarily marking failing test_lock_files_are_up_to_date test as xfail until pip-tools compatibility issue is resolved.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

@AndrewAsseily AndrewAsseily requested a review from kdaily June 19, 2025 18:44
Copy link
Member

@kdaily kdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI, LGTM

@kdaily
Copy link
Member

kdaily commented Jun 19, 2025

non-blocking - update the PR title and description since the test is marked xfail now instead of commenting out.

Squash those commits too please!

@AndrewAsseily AndrewAsseily merged commit 8fad32b into aws:v2 Jun 20, 2025
45 checks passed
@AndrewAsseily AndrewAsseily deleted the temp-lockfile-test-failures branch June 20, 2025 13:47
@AndrewAsseily AndrewAsseily changed the title Comment out temporarily failing test Mark temporarily failing test as xfail Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants