Refactored config recipe for the head node to make it easier to unit test definition of slurm services and added tests. #2711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
force-pushed
the
wip/mgiacomo/310/refactor-config-slurm-services
branch
from
90b14c2 to
a2ab106
Compare
…test definition of slurm services. Added spec tests covering the definitions of slurmctld, slurmd and slurmdbd. Signed-off-by: Giacomo Marciani <[email protected]>
gmarciani
force-pushed
the
wip/mgiacomo/310/refactor-config-slurm-services
branch
from
a2ab106 to
c8510aa
Compare
dreambeyondorange
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactored config recipe for the head node to make it easier to unit test definition of slurm services and added tests.
Added spec tests covering the definitions of slurmctld, slurmd and slurmdbd.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.