Skip to content

[Bug] Use DomainReadOnlyUser from the input provided in config #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

himani2411
Copy link
Contributor

@himani2411 himani2411 commented May 24, 2025

Description of changes

Use DomainReadOnlyUser from the input provided in config

  • Making the function case-sensitive
  • making the function stricter as cn can be part of username

Current Logs show


[2025-05-24T01:14:22+00:00] INFO: Failed to retrieve the ReadOnlyUser from CN=ReadOnlyUser,OU=Users,ou=MICROSOFTAD,DC=microsoftad,DC=kgqvfhzxwz,DC=multiuser,dc=pcluster
--
[2025-05-24T01:14:22+00:00] INFO: Falling back to the default UserName ReadOnlyUser


this is a blocker if input is CN=ReadUser,...

Tests

Cluster-creation with AD
Logs


[2025-05-27T21:07:00+00:00] INFO: Token is CN=ReadOnlyUser  and condition true ##### Log Line I added for debugging but not part of PR
[2025-05-27T21:07:00+00:00] INFO: UserName for ReadOnly directory service user set to ReadOnlyUser


References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners May 24, 2025 02:28
@himani2411 himani2411 marked this pull request as draft May 24, 2025 02:28
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (54b9986) to head (deb4057).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2961   +/-   ##
========================================
  Coverage    75.50%   75.50%           
========================================
  Files           23       23           
  Lines         2356     2356           
========================================
  Hits          1779     1779           
  Misses         577      577           
Flag Coverage Δ
unittests 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Making the function case-sensitive and strickter as `cn` can be part of user-name too
@himani2411 himani2411 marked this pull request as ready for review May 27, 2025 21:14
@himani2411 himani2411 enabled auto-merge (rebase) May 27, 2025 21:14
@himani2411 himani2411 merged commit a63e705 into aws:develop May 27, 2025
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants