fix: properly tokenize command args using shlex.split() for Windows #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The bashExecute tool was incorrectly handling command arguments by passing them as a single string for Windows. This caused issues with quoted arguments where commands like
git commit -m "test commit"
would fail due to improper argument tokenization.The validation checks for windows commands using
where
fails for built-in windows commandsSolution
shlex.split()
with the spread operator to properly tokenize argumentshelp
for checking built-in commands. This reduces constant failures we saw.Testing
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.