fix: fix for mcp permissions page for global and workspace #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bywang56
reviewed
May 27, 2025
| @@ -252,6 +257,16 @@ export class McpEventHandler { | |||
| })) | |||
| } | |||
|
|
|||
| if (existingValues.name) { | |||
| const serverName = existingValues.name | |||
| const serverState = McpManager.instance.getAllServerConfigs().get(serverName) | |||
There was a problem hiding this comment.
if customer previously select ws or global, will this choice persist when they open the plugin again?
There was a problem hiding this comment.
We can't honor unless we update the other mcp config file to remove the server from it and keep it in only in the customer's choice file.
There was a problem hiding this comment.
we don't have to remove anything, this radio button will only control where the changes is written to, not reading from.
There was a problem hiding this comment.
yes and i'm getting the values for this list from config path.
server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/mcp/mcpManager.ts
Outdated
Show resolved
Hide resolved
bywang56
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.