fix: Truncate if the servername + toolname are too long #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randall-Jiang
force-pushed
the
truncate
branch
2 times, most recently
from
20cb14a to
1aa60b5
Compare
Randall-Jiang
changed the title
chungjac
approved these changes
May 28, 2025
bywang56
reviewed
May 28, 2025
| // If truncation resulted in a conflict, fall through to suffix strategy | ||
| } | ||
| } | ||
| // Use tool name with numeric suffix (no server prefix) |
There was a problem hiding this comment.
This won't work when we retrieving the server name and tool name from toolspec right? like the places Na changed in her PR: https://github.com/aws/language-servers/pull/1451/files#diff-0da876fbe798d89b1ae25052ceca6949c8b334ed02f207f1f5c45b3d5dbeebf0
bywang56
approved these changes
May 30, 2025
| @@ -2717,8 +2733,11 @@ export class AgenticChatController implements ChatHandlers { | |||
| // Read Only Tools = All Tools - Restricted Tools (MCP + Write Tools) | |||
| // TODO: mcp tool spec name will be server___tool. | |||
| // TODO: Will also need to handle rare edge cases of long server name + long tool name > 64 char | |||
There was a problem hiding this comment.
we can remove the todos if not applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a hard limit for toolName+servername on bedrock.
Solution
Add truncation logic. To make it unique and less than required length.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.