fix: decode UTF-16LE shell output on Windows #1456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Windows we launch shell commands through
cmd.exe /c
.cmd.exe
writes legacy code‑page bytes.Because our
ExecuteBash
tool always assumedUTF‑8
, any non‑ASCII characters in the output were being mis‑decoded and displayed as??
. This affected customersSolution
UTF‑16 LE
encoding (this is how Windows handles Unicode) for all output written to the process pipes, independent of the console code‑page.• Re‑creates the raw bytes from the received string
(Buffer.from(text, 'binary'))
.• Detects
UTF‑16 LE
by checking whether every odd byte in the first 32 bytes is0x00
.• Decodes with
buffer.toString('utf16le')
when the pattern matches, otherwise falls back toUTF‑8
.Testing
Before Fix:
After Fix:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.