Fix: Convert array values to comma-separated strings in telemetry metrics emitAgencticLoop_InvokeLLM #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoxuanLu
changed the title
leigaol
reviewed
May 28, 2025
server/aws-lsp-codewhisperer/src/language-server/chat/telemetry/chatTelemetryController.ts
Outdated
Show resolved
Hide resolved
awschristou
approved these changes
May 28, 2025
leigaol
approved these changes
May 28, 2025
awschristou
approved these changes
May 28, 2025
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Flare is sending the telemetry payloads as JSON blobs, but each IDE is re-serializing this data differently. When array values like toolName, toolUseId, and latency are passed directly to the telemetry service, inconsistencies occur across different clients. The telemetry service expects literal strings, not arrays, which causes data processing issues downstream.
Solution
Modified the emitAgencticLoop_InvokeLLM method to flatten array values into comma-separated strings before emitting the telemetry metric. This ensures that each IDE receives properly formatted string values instead of arrays.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.