fix line number display in code context commands #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awschristou
reviewed
May 29, 2025
server/aws-lsp-codewhisperer/src/language-server/chat/telemetry/chatTelemetryController.ts
Outdated
Show resolved
Hide resolved
XiaoxuanLu
force-pushed
the
xiaoluk/codeLineNumber
branch
from
e014140 to
d0c74e4
Compare
awschristou
approved these changes
May 29, 2025
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Line numbers displayed in the webview were off by 1 when showing code symbol ranges. This is because the editor's internal line numbering starts at 0, but UI displays typically show line numbers starting at 1. This inconsistency affects all IDEs and creates confusion for users when they see line numbers that don't match what's shown in their editor.
VS:
VSC:
JB:
Solution
Added +1 to both the start and end line numbers when displaying the line range in the code context command description. This ensures that the line numbers shown in the UI match what users see in their editor interface, providing a consistent experience across all IDEs.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.