fix: reorder cancellation operations #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungjac
approved these changes
May 29, 2025
This was referenced May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user cancels an Amazon Q chat request, the current implementation prioritizes UI updates and telemetry before actually stopping the ongoing operations. This creates a delay in stopping processes and can lead to race conditions when follow-up prompts are sent.
Solution
Reordered the operations in the onCancellationRequested callback to prioritize aborting ongoing operations first, then update the UI, and finally send telemetry. This change ensures that when a user cancels a request:
All operations are immediately aborted (highest priority)
UI is updated to inform the user of the cancellation
Telemetry is sent (lowest priority)
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.