Skip to content

Fix GrepSearch on Windows #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025
Merged

Fix GrepSearch on Windows #1494

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f367e5d
Improve the executeBash tool spec
jngyuamz May 28, 2025
477a1f8
Remove unnecessary instructions
jngyuamz May 28, 2025
23f468e
Merge branch 'aws:main' into windows-main
jngyuamz May 30, 2025
9ce8565
Fix Windows GrepSearch
jngyuamz May 30, 2025
2255871
Merge branch 'aws:main' into windows-main
jngyuamz May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/grepSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,7 @@ export class GrepSearch {

private getRipgrepLibraryPath(): string {
if (process.platform === 'win32') {
// On Windows, the path must be loaded using a URL.
// Using the file path directly results in ERR_UNSUPPORTED_ESM_URL_SCHEME
// More details: https://github.com/nodejs/node/issues/31710
return pathToFileURL(path.join(RIPGREP_DIR, 'rg.exe')).toString()
return path.join(RIPGREP_DIR, 'rg.exe')
}

return path.join(RIPGREP_DIR, 'rg')
Expand Down
Loading