-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Swift: Add scenario example for SNS and SQS #7359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly style & Swift usage suggestions.
jbelkins
approved these changes
Apr 10, 2025
Added the scenario example for SNS and SQS. This isn't done yet. The existing filtering code is not correct and needs to come out and be replaced.
f555b23
to
6bb1e65
Compare
rlhagerm
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
On Call Review complete
On call review complete
Swift
This issue relates to the AWS SDK for Swift
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the combined scenario example for SNS and SQS. It's roughly based on the C++ implementation.
Before the code examples team reviews, I'm asking the Swift SDK team to look it over.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.