Fixed RiakHttpTransport with non-ascii streams #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Encoded data that has octets outside the 128 byte range fail in python's httplib - Using a bytearray for the message body causes the entire stream to be converted to a bytearray when a str object is added to it and the message is transported correctly - Added two tests one with unicode data in a json object and one unicode data in a string
|
Good stuff, thanks! |
seancribbs
pushed a commit
that referenced
this pull request
May 30, 2013
Fixed RiakHttpTransport with non-ascii streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python's httplib
converted to a bytearray when a str object is added to it and the
message is transported correctly
data in a string