Fixes ConflictError on non-existent objects #264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent refactoring altered the behavior of RiakObject in such a way that reading of non-existent key raises ConflictError. This seems to be a bit wrong since empty object has no conflicting siblings, in fact such an object has no siblings at all.
Proposed patch makes the RiakObject behave in the same way as before, returning None on attempt to read the empty data:
One can suggest to raise a specialized exception in case of empty siblings list - seems OK to me too.