Add timeout option for 2i requests from Riak 1.4.1. #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 6, 2013 11:26
Note that this does not include a new test, except for checking validation of the timeout value. I attempted to provoke the timeout but was unable to, even for 20K objects with a timeout of 1ms.
Also add an option to pass the timeout through next_page() when paginating indexes.
This is failing on HTTP because of bugs in Riak 1.4.1's streaming index support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not include a new test, except for checking validation of the timeout value. I attempted to provoke the timeout but was unable to, even for 20K objects with a timeout of 1ms.(fixed in second commit, discovered other bugs)