Add protobuf yokozuna admin support #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
|
||
| :rtype: bool | ||
| """ | ||
| return self.server_version >= versions[1.4] |
There was a problem hiding this comment.
This should be 2.0. Sending this to a 1.4 node will break.
|
This is good, I have no problem with the code and the tests read well and pass. However, there was some tweaking I had to do in from riak_yokozuna_pb2 import *I'd suggest adding that to Otherwise, 👍 |
|
After basho/riak_pb#56 is merged and deployed to pypi, this should be ready to merge |
coderoshi
added a commit
that referenced
this pull request
Sep 19, 2013
Add protobuf yokozuna admin support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Yokozuna admin support and tests for various search queries.
This also requires an installed riak_pb python bundle. For now, you can run
python setup.py installagainst the current riak_pb project. This project must be deployed to pypi before this PR can be merged.In order to run this, you'll need to have
yokozuna = onin yourriak.conffile, as well as run the python test with aRUN_YZ=1flag. This will activate the yokozuna tests, and deactivate riak search tests. There is no way to run both yokozuna and search tests at the same time, which is fun, since there's no way to run YZ and RS on the same server anyway.