Add support for Kotlin 2.1.20 #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
ahumesky,
cgruber,
restingbull and
nkoroste
as code owners
Bencodes
commented
Apr 9, 2025
| @@ -28,7 +28,7 @@ internal fun SourceElement.binaryClass(): String? = | |||
| when (this) { | |||
| is KotlinJvmBinarySourceElement -> binaryClass.location | |||
| is JvmPackagePartSource -> this.knownJvmBinaryClass?.location | |||
| is JavaBinarySourceElement -> this.javaClass.virtualFile.path | |||
| is VirtualFileBasedSourceElement -> this.virtualFile.path | |||
There was a problem hiding this comment.
This is a breaking change, we might be able to work around this with some less-than-amazing reflection in the short term but it'll be pretty ugly.
Bencodes
force-pushed
the
add-support-for-kotlin-2.1.20
branch
from
93bf53e to
8883ad2
Compare
|
They really aren't making it easy on us. |
restingbull
approved these changes
Apr 18, 2025
nkoroste
approved these changes
Apr 21, 2025
Bencodes
force-pushed
the
add-support-for-kotlin-2.1.20
branch
from
4c8adb8 to
e02a8be
Compare
Bencodes
force-pushed
the
add-support-for-kotlin-2.1.20
branch
from
21ae65f to
32eb56f
Compare
oliviernotteghem
pushed a commit
to uber-common/rules_kotlin
that referenced
this pull request
May 30, 2025
* Add support for Kotlin 2.1.20 * Docs * Fixes * Fix maven_install file name for 2.1.20 version * Get the compose example building again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/JetBrains/kotlin/releases/tag/v2.1.10
#1289