fix: order Prometheus histogram metrics correctly #5399
+101
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure _bucket metrics are emitted before _count and _sum, per the Prometheus text-format spec, so scrapers like fluent-bit can parse /metrics without errors. • add _fix_histogram_ordering() in PrometheusClient • sort buckets by ascending , then append count → sum • preserves non-histogram metrics; works in multi-/single-process modes • add unit tests for ordering and regression Fixes bentoml#5386
For more information, see https://pre-commit.ci
│ │ │ Fixed exception handling in extract_le_value function by choosing more specific ValueError and TypeError │ │ exceptions instead of bare except.
For more information, see https://pre-commit.ci
|
What caused us to have to use this dirty method to fix it? How does it produce output in wrong order? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Prometheus histograms must list every
_bucketbefore their_countand_sum.Out-of-order output breaks parsers like fluent-bit.
This patch guarantees the correct order for all BentoML histogram metrics.
Changes
PrometheusClient_fix_histogram_ordering()le, then appends_count,_sum.Checklist
pre-commit run -apasses.Fixes #5386