SklAdaBoostClassificationLearner: deprecate algorithm
#7118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
changed the title
algorithm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7118 +/- ##
=======================================
Coverage 88.76% 88.77%
=======================================
Files 334 334
Lines 73665 73670 +5
=======================================
+ Hits 65392 65397 +5
Misses 8273 8273 🚀 New features to boost your workflow:
|
markotoplak
force-pushed
the
deprecation-adaboost
branch
from
7202bb7 to
03994c7
Compare
|
@markotoplak, could you please rebase this to the current master? I would like to mark the new string as not needing a translation (or you can do it, if you will), but it would make a bit of a mess (possibly conflicts) if I do it on the old messages file. |
markotoplak
force-pushed
the
deprecation-adaboost
branch
from
03994c7 to
e583821
Compare
markotoplak
force-pushed
the
deprecation-adaboost
branch
from
3b8f94e to
2559efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Scikit-learn deprecated
algorithmin 1.6 (to expire in 1.8).Depends on #7117
Includes