Skip to content

TreeViewer: Escape class values #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jul 12, 2025

Issue

Fixes #7004.

@wvdvegte noticed that "Tree viewer doesn't show first category of discretized numeric variable", which is true, and also interestingly misleading. :) I assumed that it has something to do with the index 0 being falsy, while in fact the problem was that the label of the first value of categorized variable starts with a character <, and we output this as HTML.

Description of changes

Escape the label.

Includes
  • Code changes
  • Tests

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (5eb97b8) to head (7ceb2e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7124   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         334      334           
  Lines       73671    73671           
=======================================
  Hits        65402    65402           
  Misses       8269     8269           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree viewer doesn't show first category of discretized numeric variable as target
1 participant