Skip to content

Table: Add 'Clear Selection', disable 'Restore order' when order is original #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jul 12, 2025

Issue

Closes #6969.

Description of changes

I think we agreed (in the core group meeting) that the title of the box stays Variables, because it is about variables. We also said that the behaviour of the output button is consistent with other widgets in Orange and that selection behaviour is consistent with common GUIs.

I thus fixed the second point, disabling of reorder button.

As a bonus, I added a button to clear selection (which is also disabled when there's no selection). We have enough space, but its placement doesn't look nice. Perhaps move it to next to "Restore Original Order"?

Screenshot 2025-07-12 at 17 25 19
Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (5eb97b8) to head (245e3ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7125   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         334      334           
  Lines       73671    73681   +10     
=======================================
+ Hits        65402    65412   +10     
  Misses       8269     8269           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Table modifications
1 participant