Gladymir's Commit 1 Password Text Field #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybemichael
reviewed
Aug 5, 2020
Comment on lines
146
to
157
| private func setupShowHideButton() { | ||
| showHideButton.setImage(UIImage(named: "eyes-closed.png"), for: .normal) | ||
|
|
||
| addSubview(showHideButton) | ||
| showHideButton.translatesAutoresizingMaskIntoConstraints = false | ||
| showHideButton.isUserInteractionEnabled = false | ||
|
|
||
| showHideButton.trailingAnchor.constraint(equalTo: textField.trailingAnchor, constant: -standardMargin).isActive = true | ||
| showHideButton.centerYAnchor.constraint(equalTo: textField.centerYAnchor, constant: 0).isActive = true | ||
|
|
||
| showHideButton.addTarget(self, action: #selector(showHideToggled), for: .touchUpInside) | ||
| } |
There was a problem hiding this comment.
Your button isn't toggling, to give you a hint... It is one single line of code in this function right here.
Comment on lines
286
to
290
| func textFieldShouldReturn(_ textField: UITextField) -> Bool { | ||
| textField.resignFirstResponder() | ||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
You do not have your send action, so the password is not printing out because it is not being sent.
Comment on lines
163
to
192
| private func updatePasswordState(_ string: String) { | ||
| if string.count < 10 { | ||
| strengthDescriptionLabel.text = PasswordStrength.weak.rawValue | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = unusedColor | ||
| strongView.backgroundColor = unusedColor | ||
| // animateStrengthViews(weakView) | ||
| if mediumView.backgroundColor == mediumColor || weakView.backgroundColor == unusedColor { | ||
| animateStrengthViews(weakView) | ||
| } | ||
| } else if string.count < 20 { | ||
| strengthDescriptionLabel.text = PasswordStrength.medium.rawValue | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = mediumColor | ||
| strongView.backgroundColor = unusedColor | ||
| // animateStrengthViews(mediumView) | ||
| if strongView.backgroundColor == strongColor || mediumView.backgroundColor == unusedColor { | ||
| animateStrengthViews(mediumView) | ||
| } | ||
| } else if string.count >= 20 { | ||
| strengthDescriptionLabel.text = PasswordStrength.strong.rawValue | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = mediumColor | ||
| strongView.backgroundColor = strongColor | ||
| // animateStrengthViews(strongView) | ||
| if strongView.backgroundColor == unusedColor { | ||
| animateStrengthViews(strongView) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The way you currently have it set up, it is not doing the animation at all, I think you are trying to make it so it doesn't perform the animation on every single character you type. One way you could do that would be like this...
if string.count == 20 {
animateStrengthViews(strongView)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maybemichael