sprint #145
Open
sprint #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Very nice job on this sprint challenge, Ben! Your code was set up nice and clean, you constrained things well, functions were named great, and everything worked perfectly. While you didn't incorporate any stretch goals, I believe the quality of your code warrants a 3. Well done.
Comment on lines
+68
to
+70
| setupTitleLabel() | ||
| setupTextField() | ||
| setupPasswordStrengthViews() |
There was a problem hiding this comment.
I like that you broke this out into smaller functions.
Comment on lines
+175
to
+213
| private func determineStrength(for password: String) { | ||
| var newStrength: PasswordStrength | ||
|
|
||
| switch password.count { | ||
| case 0...5: | ||
| newStrength = PasswordStrength.weak | ||
| case 6...9: | ||
| newStrength = PasswordStrength.medium | ||
| default: | ||
| newStrength = PasswordStrength.strong | ||
| } | ||
|
|
||
| if passwordStrength != newStrength { | ||
| updatePasswordStrength(to: newStrength) | ||
| } | ||
| } | ||
|
|
||
| private func updatePasswordStrength(to newStrength: PasswordStrength) { | ||
| passwordStrength = newStrength | ||
| strengthDescriptionLabel.text = passwordStrength.rawValue | ||
|
|
||
| switch passwordStrength { | ||
| case .weak: | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = unusedColor | ||
| strongView.backgroundColor = unusedColor | ||
| weakView.performFlare() | ||
| case .medium: | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = mediumColor | ||
| strongView.backgroundColor = unusedColor | ||
| mediumView.performFlare() | ||
| case .strong: | ||
| weakView.backgroundColor = weakColor | ||
| mediumView.backgroundColor = mediumColor | ||
| strongView.backgroundColor = strongColor | ||
| strongView.performFlare() | ||
| } | ||
| } |
There was a problem hiding this comment.
I like that you separated out checking the strength and updating the ui into two functions.
Comment on lines
+50
to
+52
| private var passwordFieldStackView: UIStackView = UIStackView() | ||
| private var passwordStrengthStackView: UIStackView = UIStackView() | ||
| private var strengthColorsStackView: UIStackView = UIStackView() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swift-student