Reapply "Remove service client for privatenetworks (#3474)" #3476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hssyoo
approved these changes
May 20, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3476 +/- ##
===========================================
+ Coverage 92.94% 93.05% +0.11%
===========================================
Files 66 67 +1
Lines 14956 15170 +214
===========================================
+ Hits 13901 14117 +216
+ Misses 1055 1053 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamRemis
changed the title
aws-sdk-python-automation
added a commit
that referenced
this pull request
May 20, 2025
* release-1.38.20: Bumping version to 1.38.20 Update endpoints model Update to latest models Merge customizations for DataSync Reapply "Remove service client for privatenetworks (#3474)" (#3475) (#3476) Revert "Remove service client for privatenetworks (#3474)" (#3475) Add readinto to StreamingBody (#2746) Remove service client for privatenetworks (#3474)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 69473f5.
This commit was reverted after it caused an internal release issue as a way to unblock the release. The fix has now been applied upstream, so we can add back in this service deprecation