#788: added possibilit to disable logging per script #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the ability to disable logging on a per-script basis by adding an "enabled" flag to the LoggingConfig class. It updates the JSON parsing to accept the flag and modifies the logging start routine to skip log creation when logging is disabled.
- Adds an "enabled" parameter (default True) in LoggingConfig.
- Parses the "enabled" flag from JSON configuration.
- Updates the logging startup in src/execution/logging.py to check the flag before proceeding.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/model/server_conf.py | Adds the "enabled" flag to LoggingConfig and updates JSON parsing to read it. |
| src/execution/logging.py | Checks the logging configuration; if disabled, logs an info message and skips logging setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#788: added possibilit to disable logging per script