Skip to content

migrate to unittest.assertEqual #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

migrate to unittest.assertEqual #792

merged 1 commit into from
May 10, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This PR migrates from unittest.assertEquals to unittest.assertEqual which is deprecated from Python2.7 and considered bad practice to use:

DeprecationWarning: Please use assertEqual instead.

@emmanuel-ferdman
migrate to unittest.assertEqual
36bbf9e 
Signed-off-by: Emmanuel Ferdman <[email protected]>
@bugy
Copy link
Owner

bugy commented May 9, 2025

Test results: https://script-server-tests.s3-us-west-2.amazonaws.com/master/784/index.html

bugy
bugy approved these changes May 10, 2025
View reviewed changes
Copy link
Owner

@bugy bugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@bugy bugy added this to the 1.19.0 milestone May 10, 2025
@bugy bugy merged commit 23f2fac into bugy:master May 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugy bugy bugy approved these changes

Assignees
No one assigned
Labels
infrastructure resolved
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @bugy