Skip to content

[chore] add enums for error messages #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

12ya
Copy link

@12ya 12ya commented Apr 27, 2025

Summary

Test plan

Copy link

changeset-bot bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: 7617646

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 5:35pm

12ya and others added 2 commits April 29, 2025 10:13
Co-authored-by: Jakub Romańczyk <[email protected]>
Co-authored-by: Jakub Romańczyk <[email protected]>
@jbroma
Copy link
Member

jbroma commented Apr 30, 2025

Hi @12ya,

what's the rationale behind this change?

@12ya
Copy link
Author

12ya commented Apr 30, 2025

Hi @12ya,

what's the rationale behind this change?

hey, @jbroma.
thought it's gonna be good to use enums for messages instead of strings, and easier maintenance in case it gonna get larger

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't compile properly and needs to be fixed - but I'm also not sure this is worth it at this point 🤔

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants